fma: interop portal #255
Merged
fma: interop portal #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an FMA for interop support in the OptimismPortal contract.
smartcontracts
commented
Apr 9, 2025
smartcontracts
commented
Apr 9, 2025
smartcontracts
commented
Apr 9, 2025
maurelian
reviewed
Apr 17, 2025
| - Impact: CRITICAL | ||
| - Reasoning: Could lead to a **Withdrawal Safety Failure** or **Withdrawal Liveness Failure**. | ||
| - Likelihood: LOW | ||
| - Reasoning: Assumes the `AnchorStateRegistry` is well-tested and audited as a core component. |
There was a problem hiding this comment.
- has been audited a bunch
- KF: tests are comprehensive, uses fuzz testing
- should have been written with the invariants as guidance.
- @maurelian to look at test suite too.
maurelian
reviewed
Apr 17, 2025
maurelian
reviewed
Apr 17, 2025
maurelian
reviewed
Apr 17, 2025
mds1
reviewed
Apr 21, 2025
Co-authored-by: Matt Solomon <[email protected]>
mds1
approved these changes
Apr 21, 2025
maurelian
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FMA for the interop changes to the OptimismPortal contract.